Skip to content

fix: update translate-c, removal of deprecated std.ArrayListUnmanaged - #234

Open
robbielyman wants to merge 2 commits into
mainfrom
push-yztmkuzzsqvt
Open

robbielyman wants to merge 2 commits into
mainfrom
push-yztmkuzzsqvt

Conversation

@robbielyman

Copy link
Copy Markdown
Collaborator

No description provided.

@robbielyman

Copy link
Copy Markdown
Collaborator Author

@natecraddock Have you run into this CI issue? somehow Luau is failing to compile because it doesn't find basic identifiers like atoi and malloc?

@natecraddock

Copy link
Copy Markdown
Owner

I haven't seen it, I can take a look

@natecraddock

Copy link
Copy Markdown
Owner

Does this introduce incompatiblies with Zig 0.17.0?

@robbielyman

Copy link
Copy Markdown
Collaborator Author

It might, but only within the translate-c dependency.

@natecraddock

Copy link
Copy Markdown
Owner

I've been half considering dropping Luau support... Maybe this is the time to do it 🙃

https://github.com/mxpv/luaz exists, and it has better support for Luau than I'd ever have interest in supporting for ziglua...

@robbielyman

Copy link
Copy Markdown
Collaborator Author

Well, it's true that I have no real interest in Luau either, but I'd hate to drop it because of this issue

@natecraddock

Copy link
Copy Markdown
Owner

Yeah. I guess I'm just saying this reminded me of something I was already kind of wanting to do, not that this is the reason why we should.

Anyway, for now I think this should be resolved. I'll try to take another look soon

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants